GSoC`22 - Refactored workbench to react+typescript v4.0 & schema updates for latest version #532
Conversation
Signed-off-by: Omkar Phansopkar <[email protected]>
OmkarPh
requested review from
steven-esser,
AyanSinhaMahapatra and
pombredanne
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
OmkarPh
force-pushed
the
v4.0-react-typescript
branch
from
6e0b541 to
b51019b
Compare
Signed-off-by: Omkar Phansopkar <[email protected]>
* test Signed-off-by: Omkar Phansopkar <[email protected]> * Try CI release Signed-off-by: Omkar Phansopkar <[email protected]> * Updated CI Signed-off-by: Omkar Phansopkar <[email protected]> * trial 1 Signed-off-by: Omkar Phansopkar <[email protected]> * t2 Signed-off-by: Omkar Phansopkar <[email protected]> * t3 Signed-off-by: Omkar Phansopkar <[email protected]> * Platform specific tar names Signed-off-by: Omkar Phansopkar <[email protected]> * Fix workflow yml Signed-off-by: Omkar Phansopkar <[email protected]> * Fix workflow yml again Signed-off-by: Omkar Phansopkar <[email protected]> * Fix workflow yml againn Signed-off-by: Omkar Phansopkar <[email protected]> * Fix workflow yml againnn Signed-off-by: Omkar Phansopkar <[email protected]> * Fix workflow yml againnn Signed-off-by: Omkar Phansopkar <[email protected]> * Fix workflow yml againnn Signed-off-by: Omkar Phansopkar <[email protected]> * Add new release workflow job Signed-off-by: Omkar Phansopkar <[email protected]> * Updated release workflow job Signed-off-by: Omkar Phansopkar <[email protected]> * Updated release workflow job t7 Signed-off-by: Omkar Phansopkar <[email protected]> * Updated release workflow job t8 Signed-off-by: Omkar Phansopkar <[email protected]> * Updated release workflow job t8.1 Signed-off-by: Omkar Phansopkar <[email protected]> * Updated release workflow job t8.2 Signed-off-by: Omkar Phansopkar <[email protected]> * Updated release workflow job t8.3 Signed-off-by: Omkar Phansopkar <[email protected]> * Updated release workflow job t8.5 Signed-off-by: Omkar Phansopkar <[email protected]> * Updated release workflow job t8.5 Signed-off-by: Omkar Phansopkar <[email protected]> * Updated release workflow job t9 Signed-off-by: Omkar Phansopkar <[email protected]> * Updated release workflow job t9 Signed-off-by: Omkar Phansopkar <[email protected]> * Updated release workflow job t9.1 Signed-off-by: Omkar Phansopkar <[email protected]> * Updated release workflow job t9.2 Signed-off-by: Omkar Phansopkar <[email protected]> * Updated release workflow job t9.3 Signed-off-by: Omkar Phansopkar <[email protected]> * Added release workflow for linux & windows Signed-off-by: Omkar Phansopkar <[email protected]> * Matrix for OS Signed-off-by: Omkar Phansopkar <[email protected]> * Release beta 4.0.0 Signed-off-by: Omkar Phansopkar <[email protected]> * Release test Signed-off-by: Omkar Phansopkar <[email protected]> * Release test2 Signed-off-by: Omkar Phansopkar <[email protected]> * Release test3 Signed-off-by: Omkar Phansopkar <[email protected]> * Release test4 Signed-off-by: Omkar Phansopkar <[email protected]> * Release test5 Signed-off-by: Omkar Phansopkar <[email protected]> * Release test with get tag Signed-off-by: Omkar Phansopkar <[email protected]> * Update for push Signed-off-by: Omkar Phansopkar <[email protected]> * Beta release Signed-off-by: Omkar Phansopkar <[email protected]> * Arm beta Signed-off-by: Omkar Phansopkar <[email protected]> * Release arm test2 Signed-off-by: Omkar Phansopkar <[email protected]> * Release arm test3 Signed-off-by: Omkar Phansopkar <[email protected]> * Fix invalid os Signed-off-by: Omkar Phansopkar <[email protected]> * Finalized Release yml Signed-off-by: Omkar Phansopkar <[email protected]> * Removed residue code Signed-off-by: Omkar Phansopkar <[email protected]> Signed-off-by: Omkar Phansopkar <[email protected]>
…windows instead of tar Signed-off-by: Omkar Phansopkar <[email protected]>
* Powershell script in python t1 Signed-off-by: Omkar Phansopkar <[email protected]> * Powershell script in python t2 Signed-off-by: Omkar Phansopkar <[email protected]> * Removed comments Signed-off-by: Omkar Phansopkar <[email protected]> * Removed residue Signed-off-by: Omkar Phansopkar <[email protected]> Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
* Basic interface for top level packages Signed-off-by: Omkar Phansopkar <[email protected]> * Completed package & dependency definitions Signed-off-by: Omkar Phansopkar <[email protected]> * Type-classified packages Signed-off-by: Omkar Phansopkar <[email protected]> * Updated UI for beta2 release Signed-off-by: Omkar Phansopkar <[email protected]> * Created primary fields and badges Signed-off-by: Omkar Phansopkar <[email protected]> Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
There was a problem hiding this comment.
This looks great, thanks! We should merge and cut a release after reviewing.
@pombredanne could you try out and approve?
OmkarPh
changed the title
There was a problem hiding this comment.
Thanks for the hard work @OmkarPh, this is great.
I will leave it to @pombredanne and the nexB team to determine how/when they want to merge this in and release a new version.
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
credits.txt
Outdated
| @@ -0,0 +1,4 @@ | |||
| @TODO - Add these in about section - | |||
There was a problem hiding this comment.
We need an ABOUT file for this.
There was a problem hiding this comment.
hey, @pombredanne
can you share an example or basic Outline for this ABOUT file
@AyanSinhaMahapatra , maybe you've some inputs on this
There was a problem hiding this comment.
@OmkarPh sorry I missed this,
- for a package this might look like: https://github.com/nexB/thirdparty-packages/blob/main/pypi/Babel-2.10.1.tar.gz.ABOUT
- for a file: it could be like: https://github.com/nexB/scancode-toolkit/blob/develop/src/scancode/pool.py.ABOUT
Basically a download_url with license/copyright information and any other info you can find for giving credits/attribution. You might also need to add a copy of the license file if applicable, like the second example above in some cases depending on the license.
There was a problem hiding this comment.
I've created about file for the image asset https://github.com/OmkarPh/scancode-workbench/blob/v4.0-react-typescript/assets.ABOUT
I also added it in attribution window
Rest, I couldn't find any piece of code that I've directly copied from the internet
except for the official docs
There was a problem hiding this comment.
Use license instead of usage_terms, and the about file should be just beside the file which you are describing, and the filename would be: addFiles.png.ABOUT.
The terms and conditions in https://storyset.com/terms looks good to me, since it says The authorization to use the Storyset Content shall be free provided that any use of the Storyset Content by the User is credited to the Company/Website as stated by the Company from time to time. but this needs to also be reviewed by @pombredanne .
Thanks!
There was a problem hiding this comment.
The TOS are significantly more complex than the "Authorization to use...." sentence so we need to look at the whole TOS. I do not see a problem, but we need to review in more detail.
There was a problem hiding this comment.
|
Testing your PR
|
|
Also, npm install had all sorts of complaints about versions being stale and in conflict. So the good news is npm-gyp behaved. But npm thinks deps are stale and the developer should run npm audit to figure out what deps have critical updates. |
|
Thanks for your review. @martin-langhoff
yeah, 'develop' is the legacy code, so we don't expect wonders from it ;)
the schema in workbench needs some minor updates to support the latest scancode-toolkit scans, that's our next goal
we've to look for a better charts library, that handles such responsive issues
it's again because of non-updated schema ;) PS: In case you want to use the workbench for usage, other than testing |
|
hi @pombredanne |
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
* Updated schema for header info Signed-off-by: Omkar Phansopkar <[email protected]> * Updated schema & ux for license detections, packages Signed-off-by: Omkar Phansopkar <[email protected]> * License detections explorer menu Signed-off-by: Omkar Phansopkar <[email protected]> * Removed residue columns for older license format Signed-off-by: Omkar Phansopkar <[email protected]> * Merged license keys with URLs in match table Signed-off-by: Omkar Phansopkar <[email protected]> * Testing License keys parser Signed-off-by: Omkar Phansopkar <[email protected]> * Completed license detection match table UI Signed-off-by: Omkar Phansopkar <[email protected]> * Updated UX & schema for latest output LicenseDetections Signed-off-by: Omkar Phansopkar <[email protected]> * Tableview scoped filters, Header-less import, filename in titlebar, format & crash fixes Signed-off-by: Omkar Phansopkar <[email protected]> * Ignored directories when preparing chart data Signed-off-by: Omkar Phansopkar <[email protected]> * Package_data fields, file & package info dashboard, chart empty labels Signed-off-by: Omkar Phansopkar <[email protected]> * Completed all pie charts Signed-off-by: Omkar Phansopkar <[email protected]> * New window, Info dash fixes, Completed matches table, fixed flatFiles, spdx parsing for matches Signed-off-by: Omkar Phansopkar <[email protected]> --------- Signed-off-by: Omkar Phansopkar <[email protected]>
…f detection.identifier) Signed-off-by: Omkar Phansopkar <[email protected]>
OmkarPh
changed the title
Signed-off-by: Omkar Phansopkar <[email protected]>
There was a problem hiding this comment.
@OmkarPh Thanks a lot for the amazing work! This is fantastic. I've tested out the linux build locally and works great. So please go ahead and merge this as is and we'll track more improvements separately. Thank you for the quick fixes on the JSONStreams dependency issue and other open issues opened by @mjherzog too.
A few nits: we need to update the sample scans and readme to be consistent with our workbench supported versions on scancode-toolkit and also document this well enough so there's no confusion, but I'll open a separate issue for that.
Thanks ++ again
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar [email protected]